[datadog_monitors] Fix datadog_monitors datasource not failing if no monitors found
#2808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o monitors found
|
Thanks for the submission, this would help out with an issue I am facing with the DD tf provider. |
fpighi
approved these changes
May 16, 2025
unclebconnor
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2782
It is quite idiomatic with terraform datasources to have 2 datasources :
datadog_monitorin our case) that will fails if the search criteria matches 0 or more than 1 resultsdatadog_monitorsin our case) that will not fails based on the number of items matching the search criteria as it returns an array.this PR implement this policy if there is no monitors matched.